Re: [PATCH v8 02/11] dt-bindings: dma: Increase iommu maxItems for BAM DMA

Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> · Fri, 30 Jun 2023 14:05:18 +0530

Hi Krzysztof,

On 6/18/23 2:09 PM, Krzysztof Kozlowski wrote:
On 26/05/2023 21:22, Bhupesh Sharma wrote:
Since SM8450 BAM DMA engine supports five iommu entries,
increase the maxItems in the iommu property section, without
which 'dtbs_check' reports the following error:

   arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb:
     dma-controller@1dc4000: iommus: is too long

Also, please drop error message, because it is not true. The files do
not have such device node, so you cannot have such warning.

Please rewrite the commit msg to explain that certain devices, e.g.
sm8250, use more iommus.

I have sent a v9 (which can be seen here: 
<https://lore.kernel.org/linux-arm-msm/20230630082230.2264698-1-bhupesh.sharma@xxxxxxxxxx/>), 
which addresses your review comments shared on v8.

Please help review.

Thanks,
Bhupesh