Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote:
> > The "linux,keycode" property is non-standard. Add the common property
> > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake
> > is not propagated.
>
> This is actually used in the driver for this device, should the driver
> not also be updated to use the corrected property?

Yes, but that doesn't have to be in sync with the binding change. I
mainly want to add this so it doesn't get propagated to new users
rather than move this case off of linux,keycode. Also, the input
subsystem should probably have a common function to read
linux,keycodes as right now every driver does it.

Rob




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux