On Tue, Jun 13, 2023 at 12:22:58AM +0000, Azeem Shaikh wrote: > diff --git a/crypto/lrw.c b/crypto/lrw.c > index 1b0f76ba3eb5..bb8c1575645b 100644 > --- a/crypto/lrw.c > +++ b/crypto/lrw.c > @@ -359,8 +359,8 @@ static int lrw_create(struct crypto_template *tmpl, struct rtattr **tb) > if (!strncmp(cipher_name, "ecb(", 4)) { > unsigned len; > > - len = strlcpy(ecb_name, cipher_name + 4, sizeof(ecb_name)); > - if (len < 2 || len >= sizeof(ecb_name)) > + len = strscpy(ecb_name, cipher_name + 4, sizeof(ecb_name)); > + if (len < 2) > goto err_free_inst; This is wrong because 'len' is unsigned. So the -EFBIG return value is not being checked for, so this patch actually removes the overflow check. It looks like you've sent over 60 strscpy conversion patches recently (https://lore.kernel.org/linux-hardening/?q=f%3Aazeemshaikh38+s%3Astrscpy). That's concerning because this is the only one that I happened to review, and it introduces a bug. There are 60 others that could have this same bug. Can you please review all your patches for this same bug? - Eric