On Thu, Jun 01, 2023 at 03:10:18PM -0400, Mike Snitzer wrote: > > Strikes me as strange that open-coding skcipher_request_{alloc,free} > is ideal, but dm-crypt is the only non-crypto consumer of > MAX_CIPHER_BLOCKSIZE so really not worth standing up yet another > interface wrapper. It is pretty standard when you need to allocate data alongside the request. But yes if we could improve the helpers to handle this that would be nice. > Anyway, this code is certainly better for dm-crypt's needs. I'm happy > with you applying this change via your crypto tree. > > Reviewed-by: Mike Snitzer <snitzer@xxxxxxxxxx> Thanks! -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt