Hi Herbert,
On Tue, May 23, 2023 at 4:40 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote:
> > That did not fix it :-(
>
> OK, this patch should fix it:
>
> ---8<---
> A platform option like AMBA should never be selected by a driver.
> Use a dependency instead.
FTR:
arch/arm/mach-s3c/Kconfig.s3c64xx=config S3C64XX_PL080
arch/arm/mach-s3c/Kconfig.s3c64xx- def_bool DMADEVICES
arch/arm/mach-s3c/Kconfig.s3c64xx: select AMBA_PL08X
>
> Also remove the depenency on DMADEVICES because the driver builds
> just fine without it. Instead add a dependency on HAS_DMA for dma
> mapping support.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Reported-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>
> diff --git a/drivers/crypto/starfive/Kconfig b/drivers/crypto/starfive/Kconfig
> index 908c162ba79a..59002abcc0ad 100644
> --- a/drivers/crypto/starfive/Kconfig
> +++ b/drivers/crypto/starfive/Kconfig
> @@ -4,14 +4,13 @@
>
> config CRYPTO_DEV_JH7110
> tristate "StarFive JH7110 cryptographic engine driver"
> - depends on (SOC_STARFIVE || COMPILE_TEST) && DMADEVICES
> + depends on SOC_STARFIVE || AMBA_PL08X || COMPILE_TEST
> + depends on HAS_DMA
> select CRYPTO_ENGINE
> select CRYPTO_HMAC
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> select CRYPTO_SM3_GENERIC
> - select ARM_AMBA
> - select AMBA_PL08X
> help
> Support for StarFive JH7110 crypto hardware acceleration engine.
> This module provides acceleration for public key algo,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
