On Fri, May 26, 2023 at 05:48:59PM +0100, Giovanni Cabiddu wrote: > From: Damian Muszynski <damian.muszynski@xxxxxxxxx> > > Move initialization of debugfs entries to a separate file. > This simplifies the exclusion of the debugfs logic in the QAT driver > when the kernel is built with CONFIG_DEBUG_FS=n. > In addition, it will allow to consolidate the addition of debugfs > entries to a single location in the code. > > This implementation adds infrastructure to create (and remove) debugfs > entries at two different stages. The first, done when a device is probed, > allows to keep debugfs entries persistent between a transition in device > state (up to down or vice versa). The second, done after the initialization > phase, allows to have debugfs entries that are accessible only when > the device is up. > > In addition, move the creation of debugfs entries for configuration > to the newly created function adf_dbgfs_init() and replace symbolic > permissions with octal permissions when creating the debugfs files. > This is to resolve the following warning reported by checkpatch: > > WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. > > Signed-off-by: Damian Muszynski <damian.muszynski@xxxxxxxxx> > Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx> > --- > drivers/crypto/intel/qat/qat_4xxx/adf_drv.c | 12 ++-- > drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c | 12 ++-- > .../crypto/intel/qat/qat_c3xxxvf/adf_drv.c | 12 ++-- > drivers/crypto/intel/qat/qat_c62x/adf_drv.c | 12 ++-- > drivers/crypto/intel/qat/qat_c62xvf/adf_drv.c | 12 ++-- > drivers/crypto/intel/qat/qat_common/Makefile | 4 +- > drivers/crypto/intel/qat/qat_common/adf_cfg.c | 24 +++++-- > drivers/crypto/intel/qat/qat_common/adf_cfg.h | 2 + > .../crypto/intel/qat/qat_common/adf_dbgfs.c | 69 +++++++++++++++++++ > .../crypto/intel/qat/qat_common/adf_dbgfs.h | 29 ++++++++ > .../crypto/intel/qat/qat_common/adf_init.c | 6 ++ > .../crypto/intel/qat/qat_dh895xcc/adf_drv.c | 12 ++-- > .../crypto/intel/qat/qat_dh895xccvf/adf_drv.c | 12 ++-- > 13 files changed, 156 insertions(+), 62 deletions(-) > create mode 100644 drivers/crypto/intel/qat/qat_common/adf_dbgfs.c > create mode 100644 drivers/crypto/intel/qat/qat_common/adf_dbgfs.h Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
