On Thu, May 25, 2023 at 07:00:05PM +0200, Stephan Müller wrote:
> With the update of the permanent and intermittent health errors, the
> actual indicator for the health test indicates a potential error only
> for the one offending time stamp gathered in the current iteration
> round. The next iteration round will "overwrite" the health test result.
>
> Thus, the entropy collection loop in jent_gen_entropy checks for
> the health test failure upon each loop iteration. However, the
> initialization operation checked for the APT health test once for
> an APT window which implies it would not catch most errors.
>
> Thus, the check for all health errors is now invoked unconditionally
> during each loop iteration for the startup test.
>
> With the change, the error JENT_ERCT becomes unused as all health
> errors are only reported with the JENT_HEALTH return code. This
> allows the removal of the error indicator.
>
> Fixes: 3fde2fe99aa6 ("crypto: jitter - permanent and intermittent health errors"
> )
> Reported-by: Joachim Vandersmissen <git@xxxxxxxxx>
> Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx>
> ---
> crypto/jitterentropy.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
