Hi Herbert, On Wed, 2023-05-24 at 17:49 +0800, Herbert Xu wrote: > On Tue, May 16, 2023 at 04:50:07PM -0500, Tom Zanussi wrote: > . > > To choose 'fixed' mode: > > > > echo "fixed" > /sys/bus/dsa/drivers/crypto/compression_mode > > > > To choose 'canned' mode: > > > > echo "canned" > /sys/bus/dsa/drivers/crypto/compression_mode > > This seems to be a strange way to switch modes. How about just > registering both algorithms and then let the user decide which > one to use throught the algorithm name? > Yes, I think you're right. The reason we did it this way was that we're expecting to add more modes, such as 'dynamic' and/or 'canned- dynamic' etc. But I don't see a reason we couldn't just register them all and have the user choose using the algorithm names, especially if that's the way crypto users expect things to work. Thanks, Tom
