On Fri, May 19, 2023 at 03:33:34PM -0700, Randy Dunlap wrote: > Fix build warnings when DEBUG_FS is not enabled by using an empty > do-while loop instead of a value: > > In file included from ../drivers/crypto/nx/nx.c:27: > ../drivers/crypto/nx/nx.c: In function 'nx_register_algs': > ../drivers/crypto/nx/nx.h:173:33: warning: statement with no effect [-Wunused-value] > 173 | #define NX_DEBUGFS_INIT(drv) (0) > ../drivers/crypto/nx/nx.c:573:9: note: in expansion of macro 'NX_DEBUGFS_INIT' > 573 | NX_DEBUGFS_INIT(&nx_driver); > ../drivers/crypto/nx/nx.c: In function 'nx_remove': > ../drivers/crypto/nx/nx.h:174:33: warning: statement with no effect [-Wunused-value] > 174 | #define NX_DEBUGFS_FINI(drv) (0) > ../drivers/crypto/nx/nx.c:793:17: note: in expansion of macro 'NX_DEBUGFS_FINI' > 793 | NX_DEBUGFS_FINI(&nx_driver); > > Also, there is no need to build nx_debugfs.o when DEBUG_FS is not > enabled, so change the Makefile to accommodate that. > > Fixes: ae0222b7289d ("powerpc/crypto: nx driver code supporting nx encryption") > Fixes: aef7b31c8833 ("powerpc/crypto: Build files for the nx device driver") > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Breno Leitão <leitao@xxxxxxxxxx> > Cc: Nayna Jain <nayna@xxxxxxxxxxxxx> > Cc: Paulo Flabiano Smorigo <pfsmorigo@xxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > Cc: Nicholas Piggin <npiggin@xxxxxxxxx> > Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx> > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx > --- > drivers/crypto/nx/Makefile | 2 +- > drivers/crypto/nx/nx.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt