On Tue, May 23, 2023 at 10:33:38AM +0800, Herbert Xu wrote: > On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote: > > > > That did not fix it :-( > > OK, this patch should fix it: > > ---8<--- > A platform option like AMBA should never be selected by a driver. > Use a dependency instead. Randy submitted a patch to change the driver to not conflict with the arch symbols: https://lore.kernel.org/all/20230523000606.9405-1-rdunlap@xxxxxxxxxxxxx/ The corresponding change here makes sense to me, Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> @StarFive folks, you will need to go and submit a patch for arch/riscv/Kconfig.socs that selects ARM_AMBA for your platform. > Also remove the depenency on DMADEVICES because the driver builds > just fine without it. Instead add a dependency on HAS_DMA for dma > mapping support. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Reported-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > diff --git a/drivers/crypto/starfive/Kconfig b/drivers/crypto/starfive/Kconfig > index 908c162ba79a..59002abcc0ad 100644 > --- a/drivers/crypto/starfive/Kconfig > +++ b/drivers/crypto/starfive/Kconfig > @@ -4,14 +4,13 @@ > > config CRYPTO_DEV_JH7110 > tristate "StarFive JH7110 cryptographic engine driver" > - depends on (SOC_STARFIVE || COMPILE_TEST) && DMADEVICES > + depends on SOC_STARFIVE || AMBA_PL08X || COMPILE_TEST While we are changing everything, would you mind doing s/SOC/ARCH/ here? I didn't notice that while the series was being reviewed. Otherwise, I'll send you a patch for it. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
