On Tue, Apr 25, 2023 at 08:57:09PM +0800, Gaosheng Cui wrote: > The ecdh-nist-p256 algorithm will depend on jitterentropy_rng, > and when they are built into kernel, the order of registration > should be done such that the underlying algorithms are ready > before the ones on top are registered. > > Now ecdh is initialized with subsys_initcall but jitterentropy_rng > is initialized with module_init. > > This patch will change module_init(jent_mod_init) to > subsys_initcall(jent_mod_init), so jitterentropy_rng will be > registered before ecdh-nist-p256 when they are built into kernel. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@xxxxxxxxxx> > --- > crypto/jitterentropy-kcapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c > index b9edfaa51b27..563c1ea8c8fe 100644 > --- a/crypto/jitterentropy-kcapi.c > +++ b/crypto/jitterentropy-kcapi.c > @@ -205,7 +205,7 @@ static void __exit jent_mod_exit(void) > crypto_unregister_rng(&jent_alg); > } > > -module_init(jent_mod_init); > +subsys_initcall(jent_mod_init); This is unnecessary because we now postpone the testing of all algorithms until their first use. So unless something in the kernel makes use of this before/during module_init, then we don't need to move jent. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
