On Wed, Apr 19, 2023 at 2:35 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > Instead of casting the function which upsets clang for some reason, > change the assembly function siganture instead. Same comments as sha1 and sha256. Looks like more casts to remove: arch/arm/crypto/sha512-glue.c 34: (sha512_block_fn *)sha512_block_data_order); 40: (sha512_block_fn *)sha512_block_data_order); 48: (sha512_block_fn *)sha512_block_data_order); > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Link: https://lore.kernel.org/oe-kbuild-all/202304081828.zjGcFUyE-lkp@xxxxxxxxx/ > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > diff --git a/arch/arm/crypto/sha512-neon-glue.c b/arch/arm/crypto/sha512-neon-glue.c > index c879ad32db51..c6e58fe475ac 100644 > --- a/arch/arm/crypto/sha512-neon-glue.c > +++ b/arch/arm/crypto/sha512-neon-glue.c > @@ -20,8 +20,8 @@ > MODULE_ALIAS_CRYPTO("sha384-neon"); > MODULE_ALIAS_CRYPTO("sha512-neon"); > > -asmlinkage void sha512_block_data_order_neon(u64 *state, u8 const *src, > - int blocks); > +asmlinkage void sha512_block_data_order_neon(struct sha512_state *state, > + const u8 *src, int blocks); > > static int sha512_neon_update(struct shash_desc *desc, const u8 *data, > unsigned int len) > @@ -33,8 +33,7 @@ static int sha512_neon_update(struct shash_desc *desc, const u8 *data, > return sha512_arm_update(desc, data, len); > > kernel_neon_begin(); > - sha512_base_do_update(desc, data, len, > - (sha512_block_fn *)sha512_block_data_order_neon); > + sha512_base_do_update(desc, data, len, sha512_block_data_order_neon); > kernel_neon_end(); > > return 0; > @@ -49,9 +48,8 @@ static int sha512_neon_finup(struct shash_desc *desc, const u8 *data, > kernel_neon_begin(); > if (len) > sha512_base_do_update(desc, data, len, > - (sha512_block_fn *)sha512_block_data_order_neon); > - sha512_base_do_finalize(desc, > - (sha512_block_fn *)sha512_block_data_order_neon); > + sha512_block_data_order_neon); > + sha512_base_do_finalize(desc, sha512_block_data_order_neon); > kernel_neon_end(); > > return sha512_base_finish(desc, out); > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- Thanks, ~Nick Desaulniers
