On Fri, Apr 14, 2023 at 10:03:07AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The crypto dependencies for the firmwware loader are incomplete, > in particular a built-in FW_LOADER fails to link against a modular > crypto hash driver: > > ld.lld: error: undefined symbol: crypto_alloc_shash > ld.lld: error: undefined symbol: crypto_shash_digest > ld.lld: error: undefined symbol: crypto_destroy_tfm > >>> referenced by main.c > >>> drivers/base/firmware_loader/main.o:(fw_log_firmware_info) in archive vmlinux.a > > Rework this to use the usual 'select' from the driver module, > to respect the built-in vs module dependencies, and add a > more verbose crypto dependency to the debug option to prevent > configurations that lead to a link failure. > > Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > Tested on a few hundred randconfig builds > --- > drivers/base/firmware_loader/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt