On Mon, 3 Apr 2023 at 16:18, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > On 3.04.2023 08:15, Bhupesh Sharma wrote: > > On Mon, 3 Apr 2023 at 11:06, Vladimir Zapolskiy > > <vladimir.zapolskiy@xxxxxxxxxx> wrote: > >> > >> On 4/2/23 13:05, Bhupesh Sharma wrote: > >>> Currently the compatible list available in 'qce' dt-bindings does not > >>> support SM8150 and IPQ4019 SoCs directly which may lead to potential > >>> 'dtbs_check' error(s). > >>> > >>> Fix the same. > >>> > >>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > >>> --- > >>> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 6 ++++++ > >>> 1 file changed, 6 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > >>> index e375bd981300..90ddf98a6df9 100644 > >>> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > >>> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > >>> @@ -24,6 +24,12 @@ properties: > >>> deprecated: true > >>> description: Kept only for ABI backward compatibility > >>> > >>> + - items: > >>> + - enum: > >>> + - qcom,ipq4019-qce > >>> + - qcom,sm8150-qce > >>> + - const: qcom,qce > >>> + > >>> - items: > >>> - enum: > >>> - qcom,ipq6018-qce > >> > >> Two commit tags given for v2 are missing. > > > > Cannot get your comment. Please be more descriptive. > https://lore.kernel.org/linux-arm-msm/333081a2-6b31-3fca-1a95-4273b5a46fb7@xxxxxxxxxx/ I think Krzysztof mentioned (here: https://lore.kernel.org/linux-arm-msm/d5821429-032d-e1e6-3a4e-ca19eb4a60ed@xxxxxxxxxx/) and I also agree that there is no need to split the enum into const. Also, I will add the 'Fixes: 00f3bc2db351 ("dt-bindings: qcom-qce: Add new SoC compatible strings for Qualcomm QCE IP")' tag in the next version (waiting for more comments before spinning a new version). Regards, Bhupesh
