On Sat, Mar 25, 2023 at 12:01:47PM +0100, Krzysztof Kozlowski wrote: > > In that case yes, but we want COMPILE_TEST for build coverage. No we don't. Selecting OF is trivial and even the bots will cover this. We have lots of drivers under crypto that depend on COMPILE_TEST as well as OF. > > Anyway, I think adding __maybe_unused by itself is sufficient. If you really want to patch this driver then adding maybe_unused is the way to go. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt