This is helpful not just for debugging problems, but also for investigating captured logs later on. Suggested-by: Grzegorz Bernacki <gjb@xxxxxxxxxxxx> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> --- drivers/crypto/ccp/platform-access.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c index b51fb1196932..b9f94e1aeb78 100644 --- a/drivers/crypto/ccp/platform-access.c +++ b/drivers/crypto/ccp/platform-access.c @@ -157,19 +157,19 @@ int psp_ring_platform_doorbell(int msg) mutex_lock(&pa_dev->doorbell_mutex); if (check_doorbell(button)) { - dev_dbg(psp->dev, "doorbell is not ready\n"); + dev_err(psp->dev, "doorbell is not ready\n"); ret = -EBUSY; goto unlock; } if (check_recovery(cmd)) { - dev_dbg(psp->dev, "doorbell command in recovery\n"); + dev_err(psp->dev, "doorbell command in recovery\n"); ret = -EBUSY; goto unlock; } if (wait_cmd(cmd)) { - dev_dbg(psp->dev, "doorbell command not done processing\n"); + dev_err(psp->dev, "doorbell command not done processing\n"); ret = -EBUSY; goto unlock; } @@ -184,6 +184,7 @@ int psp_ring_platform_doorbell(int msg) val = FIELD_GET(PSP_CMDRESP_STS, ioread32(cmd)); if (val) { + dev_err(psp->dev, "doorbell response invalid: 0x%x\n", val); ret = -EIO; goto unlock; } -- 2.34.1