On Wed, Feb 22, 2023 at 07:22:30PM +0200, Vladimir Zapolskiy wrote: > The series contains Qualcomm Crypto Engine DT bindings documentation and > driver changes, which modify a set of accepted compatible property values, > which is needed to provide a unified and fine-grained support of the driver > on old and new platforms. In addition due to QCE IP changes on new Qualcomm > platforms, it is reflected in updates to valid device tree properties, > namely added iommu, interconnects and optional clocks. > > Qualcomm crypto engine (QCE) is available on several Snapdragon SoCs. > The QCE block supports hardware accelerated algorithms for encryption > and authentication. It also provides support for aes, des, 3des > encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256) > authentication algorithms. > > Changes since v10: > ================= > - v10 can be found here: https://lore.kernel.org/all/20230216131430.3107308-1-vladimir.zapolskiy@xxxxxxxxxx/ > - Fixed 05/10 commit message per request from Krzysztof and added his > reviewed-by tag. > - Rebased the series on top of the linux-next. > > Changes since v9: > ================= > - v9 can be found here: https://lore.kernel.org/linux-crypto/20230208183755.2907771-1-vladimir.zapolskiy@xxxxxxxxxx/ > - Added a new generic 'qcom,qce' compatible name, since IP is runtime > discoverable, however two new SoC name based compatibles are left > due to necessity to differentiate various lists of required properties. > - Updated documentation according to review comments by Krzysztof. > - Removed platform specific changes in dtsi files, only one bisectable > change in sm8550.dtsi is left in the series. > - Added some commit tags, however a few given tags by Krzysztof are not > added, since the previous tagged changes were noticeably reworked. > > Changes since v8: > ================= > - v8 can be found here: https://lore.kernel.org/all/20230202135036.2635376-1-vladimir.zapolskiy@xxxxxxxxxx/ > - Rebased the series on top of linux-next, sm8550 qce support is already > found in the tree. > - Reduced the list of QCE IP compatibles in the driver, added one more > compatible for backward DTB ABI compatibility. > - Replaced a documentation change from Neil Armstrong by a more advanced > version of it per review comments from Krzysztof Kozlowski about clock > and clock-names properties. > - Added changes to all relevant Qualcomm platform dtsi files according to > the changes in the scheme file. > - Added QCE support on SM8250 platform. > > Changes since v7: > ================= > - v7 can be found here: https://lore.kernel.org/linux-arm-msm/20220920114051.1116441-1-bhupesh.sharma@xxxxxxxxxx > - Added a change by Neil Armstrong to document clocks and clock-names > properties as optional, > - At the moment do not add Bhupesh as a new QCE driver maintainer, > - Minor updates to device tree binding documentation and qce driver, > in particular added more compatibles and fixed lesser issues. > > Changes since v6: > ================= > - v6 can be seen here: https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@xxxxxxxxxx/ > - As per Krzysztof's suggestion on v6, clubbed the crypto driver and > dt-bindings changes together. Now the overall v5 patchset into 3 > separate patchsets, one each for the following areas to allow easier > review and handling from the maintainer: arm-msm, crypto and dma > > Changes since v5: > ================= > - v5 can be seen here: https://lore.kernel.org/lkml/20211110105922.217895-1-bhupesh.sharma@xxxxxxxxxx/ > - As per Bjorn's suggestion on irc, broke down the patchset into 4 > separate patchsets, one each for the following areas to allow easier > review and handling from the maintainer: arm-msm, crypto, dma and devicetree > - Addressed Rob's, Vladimir's and Bjorn's review comments received on v5. > - Added Tested-by from Jordan received on the v5. > > Changes since v4: > ================= > - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@xxxxxxxxxx/ > - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@xxxxxxxxxx/ > - Merged the sm8150 and sm8250 enablement patches in the same patchset, > as per suggestions from Bjorn. > - Dropped a couple of patches from v4, as these have been picked by > Bjorn already via his tree. > - Addressed review comments from Vladimir, Thara and Rob. > - Collect Reviewed-by from Rob and Thara on some of the patches from the > v4 patchset. > > Changes since v3: > ================= > - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@xxxxxxxxxx/ > - Dropped a couple of patches from v3, on basis of the review comments: > ~ [PATCH 13/17] crypto: qce: core: Make clocks optional > ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info() > - Addressed review comments from Thara, Rob and Stephan Gerhold. > - Collect Reviewed-by from Rob and Thara on some of the patches from the > v3 patchset. > > Changes since v2: > ================= > - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@xxxxxxxxxx/ > - Drop a couple of patches from v1, which tried to address the defered > probing of qce driver in case bam dma driver is not yet probed. > Replace it instead with a single (simpler) patch [PATCH 16/17]. > - Convert bam dma and qce crypto dt-bindings to YAML. > - Addressed review comments from Thara, Bjorn, Vinod and Rob. > > Changes since v1: > ================= > - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@xxxxxxxxxx/ > - v1 did not work well as reported earlier by Dmitry, so v2 contains the following > changes/fixes: > ~ Enable the interconnect path b/w BAM DMA and main memory first > before trying to access the BAM DMA registers. > ~ Enable the interconnect path b/w qce crytpo and main memory first > before trying to access the qce crypto registers. > ~ Make sure to document the required and optional properties for both > BAM DMA and qce crypto drivers. > ~ Add a few debug related print messages in case the qce crypto driver > passes or fails to probe. > ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA > or the interconnect driver(s) (needed on specific Qualcomm parts) are not > yet probed. > > Bhupesh Sharma (4): > dt-bindings: qcom-qce: Convert bindings to yaml > MAINTAINERS: Add qcom-qce dt-binding file to QUALCOMM CRYPTO DRIVERS section > dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' > dt-bindings: qcom-qce: Add 'iommus' to optional properties > > Thara Gopinath (2): > crypto: qce: core: Add support to initialize interconnect path > crypto: qce: core: Make clocks optional > > Vladimir Zapolskiy (4): > dt-bindings: qcom-qce: Add new SoC compatible strings for Qualcomm QCE IP > dt-bindings: qcom-qce: document optional clocks and clock-names properties > arm64: dts: qcom: sm8550: add QCE IP family compatible values > crypto: qce: core: Add a QCE IP family compatible 'qcom,qce' > > .../devicetree/bindings/crypto/qcom-qce.txt | 25 ---- > .../devicetree/bindings/crypto/qcom-qce.yaml | 123 ++++++++++++++++++ > MAINTAINERS | 1 + > arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- > drivers/crypto/qce/core.c | 23 +++- > drivers/crypto/qce/core.h | 1 + > 6 files changed, 145 insertions(+), 30 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt > create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.yaml > > -- > 2.33.0 All applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
