On 01/03/2023 02:56, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > Add i.MX6UL, SEC 5.0 and SEC 5.4 support. > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > .../devicetree/bindings/crypto/fsl-sec4.yaml | 58 ++++++++++++++++--- > 1 file changed, 50 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml b/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml > index 678c8389ef49..1b801ae5ab51 100644 > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml > @@ -45,8 +45,18 @@ maintainers: > > properties: > compatible: > - enum: > - - fsl,sec-v4.0 > + oneOf: > + - enum: > + - fsl,sec-v4.0 > + - items: > + - enum: > + - fsl,imx6ul-caam > + - fsl,sec-v5.0 > + - const: fsl,sec-v4.0 > + - items: > + - const: fsl,sec-v5.4 > + - const: fsl,sec-v5.0 What's the point of having all these versions? Better to use SoC-compatibles. > + - const: fsl,sec-v4.0 > > "#address-cells": > const: 1 > @@ -77,6 +87,8 @@ properties: > > clock-names: > oneOf: > + - items: > + - const: ipg > - items: > - const: mem > - const: aclk > @@ -85,11 +97,17 @@ properties: > - items: > - const: aclk > - const: ipg > + - items: > + - const: ipg > + - const: aclk > - items: > - const: ipg > - const: aclk > - const: mem > > + dma-coherent: > + type: boolean > + > fsl,sec-era: > description: > Optional. A standard property. Define the 'ERA' of the SEC device. > @@ -108,8 +126,16 @@ patternProperties: > > properties: > compatible: > - enum: > - - fsl,sec-v4.0-job-ring > + oneOf: > + - enum: > + - fsl,sec-v4.0-job-ring > + - items: > + - const: fsl,sec-v5.0-job-ring > + - const: fsl,sec-v4.0-job-ring > + - items: > + - const: fsl,sec-v5.4-job-ring > + - const: fsl,sec-v5.0-job-ring > + - const: fsl,sec-v4.0-job-ring > > reg: > maxItems: 1 > @@ -148,8 +174,16 @@ patternProperties: > > properties: > compatible: > - enum: > - - fsl,sec-v4.0-rtic > + oneOf: > + - enum: > + - fsl,sec-v4.0-rtic > + - items: > + - const: fsl,sec-v5.0-rtic > + - const: fsl,sec-v4.0-rtic > + - items: > + - const: fsl,sec-v5.4-rtic > + - const: fsl,sec-v5.0-rtic > + - const: fsl,sec-v4.0-rtic This is also a bit odd... why do you version children? Best regards, Krzysztof
