Hi Heiner, On Sat, Feb 18, 2023 at 9:59 PM Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote: > + void __iomem *base = (__force void __iomem *)rng->priv; I find that "(void __force __iomem *)" is the more common order in other drivers. Which of these is correct is something I cannot tell though. Also I would like to hear some other opinions because to me the code was easier to read before. Your way is shorter and may save a few bytes (including alignment etc.) though. Best regards, Martin