On Wed, Feb 15, 2023 at 05:25:21PM +0800, Herbert Xu wrote: > /** > * struct rng_alg - random number generator definition > * > @@ -30,6 +46,7 @@ struct crypto_rng; > * size of the seed is defined with @seedsize . > * @set_ent: Set entropy that would otherwise be obtained from > * entropy source. Internal use only. > + * @stat: Statistics for rng algorithm > * @seedsize: The seed size required for a random number generator > * initialization defined with this variable. Some > * random number generators does not require a seed > @@ -39,6 +56,8 @@ struct crypto_rng; > * @base: Common crypto API algorithm data structure. > */ > struct rng_alg { > + struct crypto_alg base; > + Please keep field comments in the same order as the fields themselves. - Eric