On 08/02/2023 19:37, Vladimir Zapolskiy wrote: > Change QCE IP version specific compatible to two QCE IP family compatibles > based on SoC name and populate these two IP families with particular SoC > specific IP compatible names, which are known at the moment. > > Keep the old compatible 'qcom,crypto-v5.1' for backward compatibility > of DTB ABI, but mark it as deprecated. > > The change is based on the original one written by Bhupesh Sharma. > > Cc: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> > --- > .../devicetree/bindings/crypto/qcom-qce.yaml | 24 +++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index 4e00e7925fed..f6f1759a2f6e 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -15,7 +15,27 @@ description: > > properties: > compatible: > - const: qcom,crypto-v5.1 > + oneOf: > + - const: qcom,crypto-v5.1 > + deprecated: true > + description: Kept only for ABI backward compatibility > + - const: qcom,crypto-v5.4 You should mention in commit msg that you document existing compatible v5.4. Otherwise it looks unrelated/unexplained. Especially adding deprecated compatible is unexpected. > + deprecated: true > + description: Kept only for ABI backward compatibility Best regards, Krzysztof
