On Fri, Feb 03, 2023 at 04:48:12PM +0800, Herbert Xu wrote: > On Fri, Feb 03, 2023 at 06:36:22AM +0000, Giovanni Cabiddu wrote: > > > > The content descriptor structure (cd) is already initialized to zero > > before the function qat_alg_skcipher_init_com() is called. > > This is done in > > (1) qat_alg_skcipher_newkey() implicitly by dma_alloc_coherent(), > > the first time setkey() is called for a tfm or > > Sorry but what zeroes the memory in this case? The only zeroing > I can find in newkey is when you free the memory. dma_alloc_coherent() returns zero'd memory. When implemented originally that code used dma_zalloc_coherent(). This was phased out in Kernel 5.0 by 750afb08ca71. commit 750afb08ca71310fcf0c4e2cb1565c63b8235b60 Author: Luis Chamberlain <mcgrof@xxxxxxxxxx> Date: Fri Jan 4 09:23:09 2019 +0100 cross-tree: phase out dma_zalloc_coherent() We already need to zero out memory for dma_alloc_coherent(), as such using dma_zalloc_coherent() is superflous. Phase it out. ... Regards, -- Giovanni
