On Tue, Jan 31, 2023 at 04:01:45PM +0800, Herbert Xu wrote: > The crypto completion function currently takes a pointer to a > struct crypto_async_request object. However, in reality the API > does not allow the use of any part of the object apart from the > data field. For example, ahash/shash will create a fake object > on the stack to pass along a different data field. > > This leads to potential bugs where the user may try to dereference > or otherwise use the crypto_async_request object. > > This patch adds some temporary scaffolding so that the completion > function can take a void * instead. Once affected users have been > converted this can be removed. > > The helper crypto_request_complete will remain even after the > conversion is complete. It should be used instead of calling > the completion functino directly. Typo /s/functino/function > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>
