Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > Add a function to push the contents of a BVEC-, KVEC- or XARRAY-type > > iterator into a symmetric hash algorithm. > > There is no such thing as a symmetric hash. You're using shash > which stands for synchronous hash. Sorry, you're right. > In any case, as I said in the previous review this is abusing the > shash API. Please use ahash instead. It's already abusing the shash API, this doesn't change that, except where it gets the data from. I can have a go at conversion to ahash, but that will have to be a separate patch set as it isn't trivial. The problem is that the current code just assumes it can push bits into the hash as it gets them - this is not possible with ahash. David
