On 13/01/2023 04:51, Herbert Xu wrote: > On Sat, Dec 31, 2022 at 04:01:43PM -0600, Samuel Holland wrote: >> D1 has a crypto engine similar to the one in other Allwinner SoCs. >> Like H6, it has a separate MBUS clock gate. >> >> It also requires the internal RC oscillator to be enabled for the TRNG >> to return data, presumably because noise from the oscillator is used as >> an entropy source. This is likely the case for earlier variants as well, >> but it really only matters for H616 and newer SoCs, as H6 provides no >> way to disable the internal oscillator. >> >> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> >> --- >> I noticed that the vendor driver has code to explicitly enable IOSC when >> using the TRNG on A83T (search SS_TRNG_OSC_ADDR), but that is covered by >> a different binding/driver in mainline. >> >> Changes in v2: >> - Add TRNG clock >> >> .../bindings/crypto/allwinner,sun8i-ce.yaml | 33 ++++++++++++++----- >> 1 file changed, 25 insertions(+), 8 deletions(-) > > This doesn't have an ack from Rob Herring. Would you like me > to apply just the crypto patch by itself? But it has my Reviewed-by, which is equivalent. Please take it via crypto with the driver change. Best regards, Krzysztof
