Hi, On Thu, Dec 22, 2022 at 12:33 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > On Wed, Dec 21, 2022 at 11:41:07PM +0100, Vladis Dronov wrote: > ...skip... > > - /* ensure that the AES and tweak key are not identical */ > > + /* ensure that the AES and tweak key are not identical > > + * when in FIPS mode or the FORBID_WEAK_KEYS flag is set. > > + */ > > if ((fips_enabled || (crypto_skcipher_get_flags(tfm) & > > CRYPTO_TFM_REQ_FORBID_WEAK_KEYS)) && > > !crypto_memneq(key, key + (keylen / 2), keylen / 2)) > > Please use the kernel style for block comments: > > /* > * Ensure that the AES and tweak key are not identical when in FIPS mode > * or the FORBID_WEAK_KEYS flag is set. > */ Thanks Eric, I will wait a bit for more review notes and I will resend the patchset. Best regards, Vladis
