On 21/12/2022 10:08, Jia Jie Ho wrote:
> This adds driver support for the hardware random number generator in
> Starfive SoCs and adds StarFive TRNG entry to MAINTAINERS.
>
> Co-developed-by: Jenny Zhang <jenny.zhang@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jenny Zhang <jenny.zhang@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jia Jie Ho <jiajie.ho@xxxxxxxxxxxxxxxx>
> ---
> MAINTAINERS | 6 +
> drivers/char/hw_random/Kconfig | 11 +
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/starfive-trng.c | 403 +++++++++++++++++++++++++
> 4 files changed, 421 insertions(+)
> create mode 100644 drivers/char/hw_random/starfive-trng.c
>
(...)
> +static const struct of_device_id trng_dt_ids[] = {
> + { .compatible = "starfive,jh7110-trng" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, trng_dt_ids);
> +
> +static struct platform_driver starfive_trng_driver = {
> + .probe = starfive_trng_probe,
> + .driver = {
> + .name = "starfive-trng",
> + .pm = &starfive_trng_pm_ops,
> + .of_match_table = of_match_ptr(trng_dt_ids),
of_match_ptr goes with __maybe_unused. You will have now warnings, so
please test more your patches (W=1, sparse, smatch).
Best regards,
Krzysztof
