On Fri, Dec 16, 2022, at 17:08, Alexander Potapenko wrote:
>> The memory sanitizer causes excessive register spills in this function:
>
>> crypto/wp512.c:782:13: error: stack frame size (2104) exceeds limit (2048) in 'wp512_process_buffer' [-Werror,-Wframe-larger-than]
>
>> Assume that this one is safe, and mark it as needing no checks to
>> get the stack usage back down to the normal level.
>
> KMSAN indeed bloats the stack frames heavily.
> Wouldn't it be more preferable to further increase KMSAN's
> -Wframe-larger-than limit instead?
> It is not intended for production anyway, and detecting a runtime stack
> overflow in the debug mode should not be a problem.
I don't actually see a lot of compiler warnings with KMSAN
hitting the limit, I think we can deal with them individually.
I'd rather not raise the limit more, as that makes it harder
to identify functions that use more stack than they should.
Arnd
