Re: [PATCH v6 2/4] crypto: aria: do not use magic number offsets of aria_ctx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Herbert,
Thank you so much for your review!

On 12/2/22 19:11, Herbert Xu wrote:
> On Mon, Nov 21, 2022 at 12:39:53AM +0000, Taehee Yoo wrote:
>>
>> +#if defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64) ||  \
>> +	defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64_MODULE)
>
> Why isn't this IS_ENABLED like the hunk below?
>
>> +
>> +	/* Offset for fields in aria_ctx */
>> +	BLANK();
>> +	OFFSET(ARIA_CTX_enc_key, aria_ctx, enc_key);
>> +	OFFSET(ARIA_CTX_dec_key, aria_ctx, dec_key);
>> +	OFFSET(ARIA_CTX_rounds, aria_ctx, rounds);
>> +#endif
>> +
>>   	if (IS_ENABLED(CONFIG_KVM_INTEL)) {
>>   		BLANK();
>>   		OFFSET(VMX_spec_ctrl, vcpu_vmx, spec_ctrl);
>
> Thanks,

I missed cleaning it up.
I will use IS_ENABLED() instead of defined() in the v7.

Thanks a lot!
Taehee Yoo



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux