On Wed, Nov 23, 2022 at 5:13 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > Cc: devicetree@xxxxxxxxxxxxxxx > > Cc: Lionel Debieve <lionel.debieve@xxxxxxxxxxx> > > Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx> > > Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> (...) > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. The people reported by get_maintainers are maybe not on the CC line of the patch, but if you look at the mail header they are on the Cc: line... because I pass the not immediately relevant people to git-send-email rather than add them in the Cc tags. > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml > > index ed23bf94a8e0..69614ab51f81 100644 > > --- a/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml > > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml > > @@ -6,12 +6,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > title: STMicroelectronics STM32 CRYP bindings > > > > +description: The STM32 CRYP block is built on the CRYP block found in > > + the STn8820 SoC introduced in 2007, and subsequently used in the U8500 > > + SoC in 2010. > > + > > maintainers: > > - Lionel Debieve <lionel.debieve@xxxxxxxxxxx> > > > > properties: > > compatible: > > enum: > > + - st,stn8820-cryp > > + - stericsson,ux500-cryp > > - st,stm32f756-cryp > > - st,stm32mp1-cryp > > > > @@ -27,6 +33,19 @@ properties: > > resets: > > maxItems: 1 > > > > + dmas: > > + items: > > + - description: mem2cryp DMA channel > > + - description: cryp2mem DMA channel > > + > > + dma-names: > > + items: > > + - const: mem2cryp > > + - const: cryp2mem > > + > > + power-domains: > > + maxItems: 1 > > Are these all valid for other variants? The commit message of the patch reads: > The two properties added are DMA channels and power domain. > Power domains are a generic SoC feature and the STM32 variant > also has DMA channels. I think of power domains kind of like resets, clocks or supplies, something that is optional. > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/reset/stericsson,db8500-prcc-reset.h> > > + #include <dt-bindings/arm/ux500_pm_domains.h> > > + cryp@a03cb000 { > > Drop the example, it's almost the same and difference in one new > property does not warrant a new example. OK I drop it. Thanks for reviewing! Yours, Linus Walleij
