On 19/11/2022 14:42, Jason A. Donenfeld wrote:
The U2F zero apparently has a real TRNG in it with maximum quality, not one with quality of "1", which was likely a misinterpretation of the field as a boolean. So remove the assignment entirely, so that we get the default quality setting. In the u2f-zero firmware, the 0x21 RNG command used by this driver is handled as such [1]:
So it seems rather plain that the ATECC RNG is considered to provide good random numbers.
Thanks — at the time when it was written, there was a general concern about whether we should trust the hardware RNG of this device or not, so the safer option was not to :)
Cc: Andrej Shadura <andrew.shadura@xxxxxxxxxxxxxxx> Cc: Jiri Kosina <jkosina@xxxxxxx> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
Probably too late, but still: Acked-by: Andrej Shadura <andrew.shadura@xxxxxxxxxxxxxxx> -- Cheers, Andrej
