On 22/11/2022 07:22, Jiasheng Jiang wrote:
As the devm_kcalloc may return NULL pointer, it should be better to add check for the return value, as same as the others. Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx> --- drivers/crypto/amlogic/amlogic-gxl-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 6e7ae896717c..b243d6382664 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -238,6 +238,9 @@ static int meson_crypto_probe(struct platform_device *pdev) }mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);+ if (!mc->irqs) + return -ENOMEM; + for (i = 0; i < MAXFLOW; i++) { mc->irqs[i] = platform_get_irq(pdev, i); if (mc->irqs[i] < 0)
Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
