Hi Herbert,
Thank you so much for your review!
On 11/18/22 13:59, Herbert Xu wrote:
> On Sun, Nov 13, 2022 at 04:56:42PM +0000, Taehee Yoo wrote:
>>
>> @@ -130,6 +135,13 @@ static int aria_avx_ctr_encrypt(struct
skcipher_request *req)
>> return err;
>> }
>>
>> +static int aria_avx_init_tfm(struct crypto_skcipher *tfm)
>> +{
>> + crypto_skcipher_set_reqsize(tfm, sizeof(struct aria_avx_request_ctx));
>> +
>> + return 0;
>> +}
>> +
>> static struct skcipher_alg aria_algs[] = {
>> {
>> .base.cra_name = "__ecb(aria)",
>> @@ -160,6 +172,7 @@ static struct skcipher_alg aria_algs[] = {
>> .setkey = aria_avx_set_key,
>> .encrypt = aria_avx_ctr_encrypt,
>> .decrypt = aria_avx_ctr_encrypt,
>> + .init = aria_avx_init_tfm,
>> }
>> };
>
> You need to set the new flag CRYPTO_ALG_SKCIPHER_REQSIZE_LARGE
> or else users of sync_skcipher may pick up this algorithm and
> barf.
>
Okay, I will set CRYPTO_ALG_SKCIPHER_REQSIZE_LARGE flag in the v5 patch.
Thanks a lot!
Taehee Yoo
> Cheers,
