Hi Herbert, On Mon, Nov 7, 2022 at 3:17 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Nov 06, 2022 at 04:02:43PM +0100, Jason A. Donenfeld wrote: > > Rather than calling add_device_randomness(), the add_early_randomness() > > function should use add_hwgenerator_randomness(), so that the early > > entropy can be potentially credited, which allows for the RNG to > > initialize earlier without having to wait for the kthread to come up. > > > > This requires some minor API refactoring, by adding a `sleep_after` > > parameter to add_hwgenerator_randomness(), so that we don't hit a > > blocking sleep from add_early_randomness(). > > > > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > > --- > > Herbert - it might be easiest for me to take this patch if you want? Or > > if this will interfere with what you have going on, you can take it. Let > > me know what you feel like. -Jason > > I don't have anything that touches this file so feel free to push > it through your tree: > > Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Okay, will do. But by the way, feel free to change your mind about this if need be. For example, I sent another patch that touches core.c too (the entropy quality one). It touches different lines, so there shouldn't be a conflict, but if it's still annoying for you and you want to take them both, just pipe up and I'll drop this one from my tree. Jason
