Hi Herbert,
Thank you so much for your review!
On 11/7/22 17:48, Herbert Xu wrote:
> On Sun, Nov 06, 2022 at 02:36:24PM +0000, Taehee Yoo wrote:
>>
>> struct aria_ctx {
>> u32 enc_key[ARIA_MAX_RD_KEYS][ARIA_RD_KEY_WORDS];
>> u32 dec_key[ARIA_MAX_RD_KEYS][ARIA_RD_KEY_WORDS];
>> int rounds;
>> int key_length;
>> +#if defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64) || \
>> + defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64_MODULE)
>> + u8 keystream[ARIA_KEYSTREAM_SIZE];
>> +#endif
>> };
>
> The tfm ctx is shared between all users of the tfm. You need
> something that is private to the request so this needs to be
> moved into the reqctx.
>
> Cheers,
Sorry, I think I hadn't understood the point of your previous review
correctly.
I will move keystream into reqctx instead of the tfm.
Thanks a lot!
Taehee Yoo