On Sat, Nov 05, 2022 at 09:53:54AM +0000, Kai Ye wrote: > > +static void dfx_regs_uninit(struct hisi_qm *qm, > + struct dfx_diff_registers *dregs, int reg_len) > +{ > + int i; > + > + /* Setting the pointer is NULL to prevent double free */ > + for (i = 0; i < reg_len; i++) { > + kfree(dregs[i].regs); > + dregs[i].regs = NULL; > + } > + kfree(dregs); > + dregs = NULL; > +} The line that I complained about is still here. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt