On Wed, Oct 19, 2022 at 01:48:48PM -0500, Kalra, Ashish wrote:
> I see that other drivers are also using the same convention:
It is only convention. Look at the .rst output:
0 if the SEV successfully processed the command
-``ENODEV`` if the SEV device is not available
-``ENOTSUPP`` if the SEV does not support SEV
-``ETIMEDOUT`` if the SEV command timed out
-``EIO`` if the SEV returned a non-zero return code
vs
0 if the SEV successfully processed the command
``-ENODEV`` if the SEV device is not available
``-ENOTSUPP`` if the SEV does not support SEV
``-ETIMEDOUT`` if the SEV command timed out
``-EIO`` if the SEV returned a non-zero return code
so in the html output of this, the minus sign will be displayed either
with text font or with monospaced font as part of the error type.
I wanna say the second is better as the '-' is part of the error code
but won't waste too much time debating this. :)
Btw
$ ./scripts/kernel-doc include/linux/psp-sev.h
complains a lot. Might wanna fix those up when bored or someone else
who's reading this and feels bored too. :-)
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
