> diff --git a/lib/crypto/aesgcm.c b/lib/crypto/aesgcm.c
> +static int __init libaesgcm_init(void)
...
> + if (aesgcm_expandkey(&ctx, aesgcm_tv[i].key, aesgcm_tv[i].klen,
> + aesgcm_tv[i].clen - plen)) {
> + WARN(1, "aesgcm_expandkey() failed on vector %d\n", i);
> + return -EINVAL;
> + }
Other self-test errors in lib/crypto (blake2s, chacha20poly1305,
and curve25519) are reported with pr_err. Could you add that in
addition to the WARNs?
Also, they return -ENODEV rather than -EINVAL on self-test failures,
like this:
static int __init blake2s_mod_init(void)
{
if (!IS_ENABLED(CONFIG_CRYPTO_MANAGER_DISABLE_TESTS) &&
WARN_ON(!blake2s_selftest()))
return -ENODEV;
return 0;
}
