On Tue, Sep 27, 2022 at 11:10:07AM +0800, Peter Harliman Liem wrote: > Hi, > > I have been utilizing inside-secure driver on MaxLinear > SoC platform (which has eip197 hardware inside). > > One issue I found is that I needed to flip the endianness > in eip197_write_firmware() function, which for reason I am > not aware is using big-endian. > The firmware that I have is clearly using little-endian, > and unfortunately I do not have access to Marvell platform > to do more investigation or comparison there. > I have also tried to look for clues in Inside-Secure's > hardware/firmware documentation, without success. > > Thus, assuming each vendor may use different endian format, > on these patch set I add support for little-endian firmware > (default remains big-endian). MaxLinear platform can then > utilize the option, which is implemented as soc data. > > An alternative to this would be implementing the option > as a new device-tree property, but for now I assume we do > not need that since each platform endianness should be > fixed, and will not vary per board/hardware. > > Please help review. > > Thanks! > > v2: > Revert directory change for generic case. > Add missing driver data change in pci_device_id. > Rename data struct to safexcel_priv_data. > Rework endianness selection code casting, to fix warning caught by kernel test robot. > Rename mxl version string to eip197 'c'. > > Peter Harliman Liem (3): > crypto: inside-secure - Expand soc data structure > crypto: inside-secure - Add fw_little_endian option > crypto: inside-secure - Add MaxLinear platform > > drivers/crypto/inside-secure/safexcel.c | 69 ++++++++++++++++++------- > drivers/crypto/inside-secure/safexcel.h | 10 +++- > 2 files changed, 59 insertions(+), 20 deletions(-) > > -- > 2.17.1 All applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt