On Wed, Oct 12, 2022 at 04:59:29PM -0500, Robert Elliott wrote: > Reword prints that the module is not being loaded (although > it otherwise qualifies) because performance would be suboptimal > on the particular CPU model. > > Although modules are not supposed to print unless they're loaded > and active, this is an existing exception. > > Signed-off-by: Robert Elliott <elliott@xxxxxxx> > --- > arch/x86/crypto/blowfish_glue.c | 5 +---- > arch/x86/crypto/camellia_glue.c | 5 +---- > arch/x86/crypto/des3_ede_glue.c | 2 +- > arch/x86/crypto/twofish_glue_3way.c | 5 +---- > 4 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/arch/x86/crypto/blowfish_glue.c b/arch/x86/crypto/blowfish_glue.c > index 27b7aed9a488..8d4ecf406dee 100644 > --- a/arch/x86/crypto/blowfish_glue.c > +++ b/arch/x86/crypto/blowfish_glue.c > @@ -320,10 +320,7 @@ static int __init blowfish_init(void) > return -ENODEV; > > if (!force && is_blacklisted_cpu()) { > - printk(KERN_INFO > - "blowfish-x86_64: performance on this CPU " > - "would be suboptimal: disabling " > - "blowfish-x86_64.\n"); > + pr_info("CPU-optimized crypto module not loaded, crypto optimization performance on this CPU would be suboptimal\n"); This is a comma splice. You need some sort of conjunction. But also: it's not like the user can do anything about this. Why clutter dmesg? Seems like we'd be better off without these messages?