I haven't looked at this in depth yet, but one thing jumped out: On Fri, Oct 07, 2022 at 05:21:05PM +0200, Ard Biesheuvel wrote: > Implement a minimal library version of GCM based on the existing library > include/crypto/gcm.h | 61 ++ > lib/crypto/gcm.c | 714 ++++++++++++++++++++ > +void gcm_encrypt(const struct gcm_ctx *ctx, u8 *dst, const u8 *src, > + int crypt_len, const u8 *assoc, int assoc_len, > + const u8 iv[GCM_AES_IV_SIZE], u8 *authtag); This should probably all be aes_gcm, aes-gcm.[ch] LIB_AES_GCM and so forth, since GCM is something that works with different block ciphers. Jason
