On 23/9/2022 5:09 pm, Antoine Tenart wrote:
> Quoting Peter Harliman Liem (2022-09-20 10:01:37)
>> + default:
>> + /* generic case */
>> + dir = "";
>> + }
>
> Why "generic case"? We shouldn't end up in this case and the logic
> changed after this patch: an error was returned before.
>
> The if vs switch is mostly a question of taste here, I don't have
> anything against it but it's also not necessary as we're not supporting
> lots of versions. So you could keep it as-is and keep the patch
> restricted to its topic.
This change has been removed in v2.
>> {
>> .compatible = "inside-secure,safexcel-eip197",
>> - .data = (void *)EIP197B_MRVL,
>> + .data = &eip197b_mrvl_data,
>> },
>> {},
>> };
>
> The pci_device_id counterpart update is missing.
I missed that. Thanks for catching.
Updated in v2.
>> +struct safexcel_of_data {
>> + enum safexcel_eip_version version;
>> +};
>
> The driver supports both of and PCI ids, you can rename this to
> safexcel_priv_data.
Updated in v2.
Thanks!
-Peter-
