On Wed, Sep 7, 2022 at 8:34 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > diff --git a/drivers/char/random.c b/drivers/char/random.c > > index 79d7d4e4e582..b360ed4ece03 100644 > > --- a/drivers/char/random.c > > +++ b/drivers/char/random.c > > @@ -867,9 +867,9 @@ void add_hwgenerator_randomness(const void *buf, size_t len, size_t entropy) > > > > /* > > * Throttle writing to once every CRNG_RESEED_INTERVAL, unless > > - * we're not yet initialized. > > + * we're not yet initialized or this source isn't trusted. > > */ > > - if (!kthread_should_stop() && crng_ready()) > > + if (!kthread_should_stop() && (crng_ready() || !entropy)) > > schedule_timeout_interruptible(CRNG_RESEED_INTERVAL); > > } > > EXPORT_SYMBOL_GPL(add_hwgenerator_randomness); > > Couldn't you split this bit out? It's been two weeks and Dominik hasn't posted anything new, so I'm going to do that for him. Patch incoming (retaining his authorship). Jason
