Re: [PATCH 0/2] crypto: intel-fcs: Add crypto service driver for Intel SoCFPGA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/09/2022 06:25, wen.ping.teh@xxxxxxxxx wrote:
From: wen.ping.teh@xxxxxxxxx

This patch introduces a crypto service driver for Intel SoCFPGA
family. The FPGA Crypto Service (FCS) includes a large set of security
features that are provided by the Secure Device Manager(SDM) in FPGA.
The driver provide IOCTL interface for user to call the crypto services
and send them to SDM's mailbox.

Teh Wen Ping (2):
  crypto: intel-fcs: crypto service driver for Intel SoCFPGA family
  arm64: defconfig: add CRYPTO_DEV_INTEL_FCS
Hi,

I just found out that there was a previous attempt to upstream this driver
2 years ago. It was NACK because it did not implement crypto API. Please
drop this review.
https://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg44701.html

I will move this driver to drivers/misc.

I think the proper solution would be to implement the existing API first rather than adding a set of custom proprietary IOCTLs that nobody else is going to use.

--
With best wishes
Dmitry




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux