On Thu, Aug 25, 2022 at 11:30 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > + writel_relaxed(hstate->csfull, &device_data->base->csfull); > > + writel_relaxed(hstate->csdatain, &device_data->base->csdatain); > > + writel_relaxed(hstate->str_reg, &device_data->base->str); > > + writel_relaxed(cr, &device_data->base->cr); > > + > > + return 0; > > } > > At any time we may have multiple requests outstanding for a given > tfm/device, so I'm a bit worried with the direct writes to hardware > in the import function. > > Normally import just transfers data from the caller into the > request object as a "soft" state, while the actual update/final > functions will then move them into the hardware state as needed. I see the problem. Do you think we could merge patches 1 thru 9 for this kernel cycle though to lower my patch stack? I can resend just those if you like. Yours, Linus Walleij