Re: [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/9/2022 10:01 pm, Antoine Tenart wrote:
> Quoting Peter Harliman Liem (2022-09-06 04:51:49)
>> From commit d03c54419274 ("dma-mapping: disallow .map_sg
>> operations from returning zero on error"), dma_map_sg()
>> produces warning if size is 0. This results in visible
>> warnings if crypto length is zero.
>> To avoid that, we avoid calling dma_map_sg if size is zero.
>>
>> Fixes: d03c54419274 ("dma-mapping: disallow .map_sg operations from returning zero on error")
> 
> You can't reference the commit above, it's not introducing the issue but
> the warning itself. The actual commit introducing the below logic should
> be referenced.
> 
> Alternatively since the warning was introduced latter than the logic and
> this is not a huge issue, you might resend it w/o the Fixes tag as well.
Noted.
I will remove the tag in v3.

Thanks!







[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux