On Thu, Aug 25, 2022 at 10:04:56PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > CRYPTO_LIB_CHACHA_GENERIC doesn't need to select XOR_BLOCKS. It perhaps > was thought that it's needed for __crypto_xor, but that's not the case. > > Enabling XOR_BLOCKS is problematic because the XOR_BLOCKS code runs a > benchmark when it is initialized. That causes a boot time regression on > systems that didn't have it enabled before. > > Therefore, remove this unnecessary and problematic selection. > > Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > > I've separated this fix out from the larger patch > https://lore.kernel.org/r/20220725183636.97326-3-ebiggers@xxxxxxxxxx > that is currently queued in cryptodev. > > lib/crypto/Kconfig | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt