Hi Jack,
On Fri, Aug 19, 2022 at 9:08 AM Jack Wang <jinpu.wang@xxxxxxxxx> wrote:
>
> dma_map_sg return 0 on error, and dma_map_error is not supposed to use
> here.
>
> Cc: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
>
> Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> ---
> drivers/crypto/ccree/cc_buffer_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccree/cc_buffer_mgr.c b/drivers/crypto/ccree/cc_buffer_mgr.c
> index 6140e4927322..9efd88f871d1 100644
> --- a/drivers/crypto/ccree/cc_buffer_mgr.c
> +++ b/drivers/crypto/ccree/cc_buffer_mgr.c
> @@ -274,7 +274,7 @@ static int cc_map_sg(struct device *dev, struct scatterlist *sg,
> }
>
> ret = dma_map_sg(dev, sg, *nents, direction);
> - if (dma_mapping_error(dev, ret)) {
> + if (!ret) {
> *nents = 0;
> dev_err(dev, "dma_map_sg() sg buffer failed %d\n", ret);
> return -ENOMEM;
> --
> 2.34.1
>
Good catch!
Thank you for the patch.
Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
values of β will give rise to dom!
