On Wed, Jul 20, 2022 at 03:28:44PM +0200, Christophe JAILLET wrote: > There is no point in calling dma_supported() before calling > dma_set_coherent_mask(). This function already calls dma_supported() and > returns an error (-EIO) if it fails. > > So remove the superfluous dma_supported() call. > > Moreover, setting a larger DMA mask will never fail when setting a smaller > one will succeed, so the whole "while" loop can be removed as well. (see > [1]) > > While at it, fix the name of the function reported in a dev_err(). > > [1]: https://lore.kernel.org/all/YteQ6Vx2C03UtCkG@xxxxxxxxxxxxx/ > > Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > drivers/crypto/ccree/cc_driver.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
