Hi Adhemerval,
On Tue, Jul 26, 2022 at 01:20:11PM -0300, Adhemerval Zanella Netto wrote:
> > + {
> > + atomic_store_relaxed (&have_getrandom, false);
>
> I still think there is no much gain in this optimization, the syscall will
> most likely be present and it is one less static data. Also, we avoid to
> use __ASSUME_GETRANDOM on generic code (all __ASSUME usage within
> sysdeps and/or nptl).
Oh! *That's* what you were talking about before. Sorry I didn't catch
your meaning the first time through.
Okay so you're alright having +1 syscall overhead on old systems, so
that new systems can have a byte less of static data. I don't hold any
opinions either way there and will defer to your expertise, so I'll get
rid of this part on v5.
> > + __ppoll_infinity_nocancel;
> > __sigtimedwait;
> > # functions used by nscd
> > __netlink_assert_response;
>
> There is no need to export on GLIBC_PRIVATE, since it is not currently usage
> libc.so. Just define is a hidden (attribute_hidden).
> Use attribute_hidden here and remove it from sysdeps/unix/sysv/linux/Versions.
>> Maybe just add an inline wrapper on sysdeps/unix/sysv/linux/not-cancel.h,
> as for __getrandom_nocancel:
> It avoids a lot of boilerplate code to add the internal symbol.
Okay I'll skip all the symbol stuff and just do the static inline like
getrandom has. Thanks for the suggestion; that's a lot simpler.
> Also update the hurd sysdeps/mach/hurd/not-cancel.h with a wrapper to
> __poll (since it does not really support pthread cancellation).
Ack.
Thanks for the comments. v5 coming up shortly.
Jason
